Merge pull request #6 from JohannesDeml/litenetlib-performance

Litenetlib performance

Author: JohannesDeml

.gitmodules

@@ -0,0 +1,3 @@
+[submodule "LiteNetLib"]
+	path = LiteNetLib
+	url = git@github.com:RevenantX/LiteNetLib.git

Benchmarks/ubuntu-0.2.1.md

@@ -0,0 +1,119 @@
+## Benchmarks
+
+To reproduce the benchmarks, run `./NetCoreNetworkBenchmark -b`
+
+
+```
+OS: Ubuntu 20.04.1 LTS
+CPU: Intel® Core™ i5-3570K CPU @ 3.40GHz × 4
+Mainboard:  Gigabyte Z77X-D3H Gb LAN (Atheros)
+RAM: G.Skill 16GB (2 x 8 GB) DDR3-1600 (Part number: F3-1600C11-8GNT)
+```
+### Benchmark 1 (v 0.2.1)
+* `./NetCoreNetworkBenchmark -t PingPong -l LiteNetLib -a 127.0.0.1 -p 3333 -c 1000 -s 32 -x Random -m 1 -d 60`
+* OS: Linux 5.4.0-52-generic #57-Ubuntu SMP Thu Oct 15 10:57:00 UTC 2020 X64
+* Framework: .NET Core 3.1.9
+* Test: PingPong
+* Address: 127.0.0.1, Port: 3333
+* Number of clients: 1000
+* Parallel messages per client: 1
+* Message size: 32 bytes
+* Message Payload: Random
+* Defined duration: 60 seconds
+
+#### ENet
+```
+Duration: 60.008 s
+Messages sent by clients: 11,613,436
+Messages server received: 11,612,476
+Messages sent by server: 11,612,475
+Messages clients received: 11,612,436
+
+Total data: 354.38 MB
+Data throughput: 5.91 MB/s
+Message throughput: 193,515 msg/s
+Message latency: 5.168 μs
+```
+
+#### LiteNetLib
+```
+Duration: 60.092 s
+Messages sent by clients: 3,915,508
+Messages server received: 3,915,362
+Messages sent by server: 3,914,945
+Messages clients received: 3,914,508
+
+Total data: 119.46 MB
+Data throughput: 1.99 MB/s
+Message throughput: 65,142 msg/s
+Message latency: 15.351 μs
+```
+
+#### NetCoreServer
+```
+Duration: 60.005 s
+Messages sent by clients: 6,604,598
+Messages server received: 6,603,735
+Messages sent by server: 6,603,733
+Messages clients received: 6,603,617
+
+Total data: 201.53 MB
+Data throughput: 3.36 MB/s
+Message throughput: 110,051 msg/s
+Message latency: 9.087 μs
+```
+
+### Benchmark 2 (v 0.2.1)
+* `./NetCoreNetworkBenchmark -t PingPong -l NetCoreServer -a 127.0.0.1 -p 3333 -c 100 -s 32 -x Random -m 1000 -d 60`
+* OS: Linux 5.4.0-52-generic #57-Ubuntu SMP Thu Oct 15 10:57:00 UTC 2020 X64
+* Framework: .NET Core 3.1.9
+* Test: PingPong
+* Address: 127.0.0.1, Port: 3333
+* Number of clients: 100
+* Parallel messages per client: 1,000
+* Message size: 32 bytes
+* Message Payload: Random
+* Defined duration: 60 seconds
+
+#### ENet
+```
+Duration: 60.017 s
+Messages sent by clients: 129,111,780
+Messages server received: 129,011,781
+Messages sent by server: 129,011,780
+Messages clients received: 129,011,780
+
+Total data: 3937.13 MB
+Data throughput: 65.60 MB/s
+Message throughput: 2,149,574 msg/s
+Message latency: 0.465 μs
+```
+
+#### LiteNetLib
+```
+Duration: 60.012 s
+Messages sent by clients: 28,786,912
+Messages server received: 28,696,204
+Messages sent by server: 28,687,309
+Messages clients received: 28,686,912
+
+Total data: 875.46 MB
+Data throughput: 14.59 MB/s
+Message throughput: 478,019 msg/s
+Message latency: 2.092 μs
+```
+
+#### NetCoreServer
+```
+Duration: 60.591 s
+Messages sent by clients: 7,296,041
+Messages server received: 7,197,985
+Messages sent by server: 7,197,984
+Messages clients received: 7,196,543
+
+Total data: 219.62 MB
+Data throughput: 3.62 MB/s
+Message throughput: 118,773 msg/s
+Message latency: 8.419 μs
+```
+

LiteNetLib

@@ -2,6 +2,8 @@
 Microsoft Visual Studio Solution File, Format Version 12.00
 Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "NetCoreNetworkBenchmark", "NetCoreNetworkBenchmark\NetCoreNetworkBenchmark.csproj", "{A1025393-381A-4EB0-98C7-36A0FA7A4685}"
 EndProject
+Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "LiteNetLib", "LiteNetLib\LiteNetLib\LiteNetLib.csproj", "{79DF5167-DF79-489F-AAF5-2F39236ED7B6}"
+EndProject
 Global
 	GlobalSection(SolutionConfigurationPlatforms) = preSolution
 		Debug|Any CPU = Debug|Any CPU
@@ -12,5 +14,9 @@ Global
 		{A1025393-381A-4EB0-98C7-36A0FA7A4685}.Debug|Any CPU.Build.0 = Debug|Any CPU
 		{A1025393-381A-4EB0-98C7-36A0FA7A4685}.Release|Any CPU.ActiveCfg = Release|Any CPU
 		{A1025393-381A-4EB0-98C7-36A0FA7A4685}.Release|Any CPU.Build.0 = Release|Any CPU
+		{79DF5167-DF79-489F-AAF5-2F39236ED7B6}.Debug|Any CPU.ActiveCfg = Debug|Any CPU
+		{79DF5167-DF79-489F-AAF5-2F39236ED7B6}.Debug|Any CPU.Build.0 = Debug|Any CPU
+		{79DF5167-DF79-489F-AAF5-2F39236ED7B6}.Release|Any CPU.ActiveCfg = Release|Any CPU
+		{79DF5167-DF79-489F-AAF5-2F39236ED7B6}.Release|Any CPU.Build.0 = Release|Any CPU
 	EndGlobalSection
 EndGlobal

NetCoreNetworkBenchmark.sln

@@ -35,11 +35,11 @@ internal class BenchmarkConfiguration
 		/// </summary>
 		public string Address = "127.0.0.1";
 
-		public bool PrintSteps = true;
+		public bool Verbose = true;
 
 		public string Name = "Custom";
 
-		public int NumClients = 1000;
+		public int NumClients = 100;
 		public int ParallelMessagesPerClient = 1;
 		public int MessageByteSize = 32;
 		public MessagePayload MessagePayload = MessagePayload.Ones;
@@ -48,7 +48,7 @@ internal class BenchmarkConfiguration
 		public int TickRateServer = 60;
 
 		public byte[] Message { get; private set; }
-		public int TestDurationInSeconds = 2;
+		public int TestDurationInSeconds = 10;
 
 		public BenchmarkConfiguration()
 		{

NetCoreNetworkBenchmark/BenchmarkConfiguration.cs

@@ -21,7 +21,6 @@ internal class EchoClient
 		private readonly EventBasedNetListener listener;
 		private readonly NetManager netManager;
 		private NetPeer peer;
-		private Task listenTask;
 
 		public EchoClient(int id, BenchmarkConfiguration config)
 		{
@@ -33,6 +32,9 @@ public EchoClient(int id, BenchmarkConfiguration config)
 
 			listener = new EventBasedNetListener();
 			netManager = new NetManager(listener);
+			netManager.IPv6Enabled = IPv6Mode.Disabled;
+			netManager.UnsyncedEvents = true;
+			netManager.DisconnectTimeout = 10000;
 
 			IsConnected = false;
 			IsDisposed = false;
@@ -45,7 +47,8 @@ public EchoClient(int id, BenchmarkConfiguration config)
 
 		public void Start()
 		{
-			listenTask = Task.Factory.StartNew(ConnectAndListen, TaskCreationOptions.LongRunning);
+			netManager.Start();
+			peer = netManager.Connect(config.Address, config.Port, "ConnectionKey");
 			IsDisposed = false;
 		}
 
@@ -55,8 +58,9 @@ public void StartSendingMessages()
 
 			for (int i = 0; i < parallelMessagesPerClient; i++)
 			{
-				Send(message, DeliveryMethod.Unreliable);
+				Send(message, DeliveryMethod.ReliableUnordered);
 			}
+			netManager.TriggerUpdate();
 		}
 
 		public Task Disconnect()
@@ -66,13 +70,6 @@ public Task Disconnect()
 				return Task.CompletedTask;
 			}
 
-			if (peer == null)
-			{
-				Console.WriteLine($"Client {id} does not know peer even though it was connected, should not happen.");
-				IsConnected = false;
-				return Task.CompletedTask;
-			}
-
 			var clientDisconnected = Task.Factory.StartNew(() =>
 			{
 				peer.Disconnect();
@@ -92,15 +89,8 @@ public Task Stop()
 			return stopClient;
 		}
 
-		public async void Dispose()
+		public void Dispose()
 		{
-			while (!listenTask.IsCompleted)
-			{
-				await Task.Delay(10);
-			}
-
-			listenTask.Dispose();
-
 			listener.PeerConnectedEvent -= OnPeerConnected;
 			listener.PeerDisconnectedEvent -= OnPeerDisconnected;
 			listener.NetworkReceiveEvent -= OnNetworkReceive;
@@ -109,30 +99,11 @@ public async void Dispose()
 			IsDisposed = true;
 		}
 
-		private void ConnectAndListen()
-		{
-			netManager.Start();
-			peer = netManager.Connect(config.Address, config.Port, "LiteNetLib");
-
-			while (benchmarkData.Running || IsConnected)
-			{
-				netManager.PollEvents();
-				Thread.Sleep(tickRate);
-			}
-		}
-
 		private void Send(byte[] bytes, DeliveryMethod deliverymethod)
 		{
-			if (peer == null)
+			if (!IsConnected)
 			{
-				Interlocked.Increment(ref benchmarkData.Errors);
-				if (netManager.FirstPeer == null)
-				{
-					Console.WriteLine($"Client {id} is missing the reference to the server");
-					return;
-				}
-
-				peer = netManager.FirstPeer;
+				return;
 			}
 
 			peer.Send(bytes, deliverymethod);
@@ -146,6 +117,11 @@ private void OnPeerConnected(NetPeer peer)
 
 		private void OnPeerDisconnected(NetPeer peer, DisconnectInfo disconnectInfo)
 		{
+			if (disconnectInfo.Reason == DisconnectReason.Timeout && benchmarkData.Running)
+			{
+				Utilities.WriteVerboseLine($"Client {id} disconnected due to timeout. Probably the server is overwhelmed by the requests.");
+				Interlocked.Increment(ref benchmarkData.Errors);
+			}
 			this.peer = null;
 			IsConnected = false;
 		}
@@ -156,6 +132,7 @@ private void OnNetworkReceive(NetPeer peer, NetPacketReader reader, DeliveryMeth
 			{
 				Interlocked.Increment(ref benchmarkData.MessagesClientReceived);
 				Send(message, deliverymethod);
+				netManager.TriggerUpdate();
 			}
 
 			reader.Recycle();
@@ -165,6 +142,7 @@ private void OnNetworkError(IPEndPoint endpoint, SocketError socketerror)
 		{
 			if (benchmarkData.Running)
 			{
+				Utilities.WriteVerboseLine($"Error Client {id}: {socketerror}");
 				Interlocked.Increment(ref benchmarkData.Errors);
 			}
 		}

NetCoreNetworkBenchmark/LiteNetLib/EchoClient.cs

@@ -11,12 +11,10 @@ internal class EchoServer
 	{
 		private readonly BenchmarkConfiguration config;
 		private readonly BenchmarkData benchmarkData;
-		private readonly Thread serverThread;
 		private readonly EventBasedNetListener listener;
 		private readonly NetManager netManager;
 		private readonly byte[] message;
 		private readonly int tickRate;
-		private bool isRunning;
 
 		public EchoServer(BenchmarkConfiguration config)
 		{
@@ -27,48 +25,40 @@ public EchoServer(BenchmarkConfiguration config)
 			listener = new EventBasedNetListener();
 			netManager = new NetManager(listener);
 			netManager.UpdateTime = tickRate;
-			message = new byte[config.MessageByteSize];
+			netManager.IPv6Enabled = IPv6Mode.Disabled;
+			netManager.UnsyncedEvents = true;
 
-			serverThread = new Thread(this.Start);
-			serverThread.Name = "LiteNetLib Server";
+			message = new byte[config.MessageByteSize];
 
 			listener.ConnectionRequestEvent += OnConnectionRequest;
 			listener.NetworkReceiveEvent += OnNetworkReceive;
 			listener.NetworkErrorEvent += OnNetworkError;
 		}
 
-		public Task StartServerThread()
+		public Task StartServer()
 		{
-			serverThread.Start();
-			var serverStarted = Task.Run(() =>
+			Start();
+			var serverStopped = Task.Run(() =>
 			{
-				while (!serverThread.IsAlive)
+				while (!netManager.IsRunning)
 				{
 					Task.Delay(10);
 				}
 			});
-			return serverStarted;
+			return serverStopped;
 		}
 
 		private void Start()
 		{
-			isRunning = true;
 			netManager.Start(config.Port);
-
-			while (isRunning)
-			{
-				netManager.PollEvents();
-				Thread.Sleep(tickRate);
-			}
 		}
 
-		public Task StopServerThread()
+		public Task StopServer()
 		{
-			isRunning = false;
 			netManager.Stop();
 			var serverStopped = Task.Run(() =>
 			{
-				while (serverThread.IsAlive)
+				while (netManager.IsRunning)
 				{
 					Task.Delay(10);
 				}
@@ -104,6 +94,7 @@ private void OnNetworkReceive(NetPeer peer, NetPacketReader reader, DeliveryMeth
 				Buffer.BlockCopy(reader.RawData, reader.UserDataOffset, message, 0, reader.UserDataSize);
 				peer.Send(message, deliverymethod);
 				Interlocked.Increment(ref benchmarkData.MessagesServerSent);
+				netManager.TriggerUpdate();
 			}
 
 			reader.Recycle();