Draft
Conversation
Added the parameter `N` to history, indicating the number of marginal processes in the multivariate point process. Added methods to access the marginal histories and counts. Virtually no change in implementation was necessary for univariate processes to keep working as before.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| append!(sim, sim_desc) | ||
| sort!(sim) | ||
| return History(; times=sim, tmin=tmin, tmax=tmax, check=false) | ||
| return History(sim, tmin, tmax, check_args=false) |
Contributor
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| return History(sim, tmin, tmax, check_args=false) | |
| return History(sim, tmin, tmax; check_args=false) |
|
|
||
| # Type parameter for `HawkesProcess` was NOT explicitly provided | ||
| function StatsAPI.fit(HP::Type{HawkesProcess}, h::History{H,M}; kwargs...) where {H<:Real,M} | ||
| function StatsAPI.fit(HP::Type{<:HawkesProcess}, h::UnivariateHistory{H,M}; kwargs...) where {H<:Real,M} |
Contributor
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| function StatsAPI.fit(HP::Type{<:HawkesProcess}, h::UnivariateHistory{H,M}; kwargs...) where {H<:Real,M} | |
| function StatsAPI.fit( | |
| HP::Type{<:HawkesProcess}, h::UnivariateHistory{H,M}; kwargs... | |
| ) where {H<:Real,M} |
| end | ||
| end | ||
| end | ||
| function History{N}(times::Vector{<:Real}, tmin::Real, tmax::Real, marks::Vector, dims::Vector{<:Int}; check_args::Bool=true) where {N} |
Contributor
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| function History{N}(times::Vector{<:Real}, tmin::Real, tmax::Real, marks::Vector, dims::Vector{<:Int}; check_args::Bool=true) where {N} | |
| function History{N}( | |
| times::Vector{<:Real}, | |
| tmin::Real, | |
| tmax::Real, | |
| marks::Vector, | |
| dims::Vector{<:Int}; | |
| check_args::Bool=true, | |
| ) where {N} |
| new{N,T,M,D}(times, tmin, tmax, marks, dims) | ||
| end | ||
|
|
||
| function History{1}(times::Vector{<:Real}, tmin::Real, tmax::Real, marks::Vector, ::Any; check_args::Bool=true) |
Contributor
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| function History{1}(times::Vector{<:Real}, tmin::Real, tmax::Real, marks::Vector, ::Any; check_args::Bool=true) | |
| function History{1}( | |
| times::Vector{<:Real}, | |
| tmin::Real, | |
| tmax::Real, | |
| marks::Vector, | |
| ::Any; | |
| check_args::Bool=true, | |
| ) |
Comment on lines
+50
to
+51
| (tmin, tmax), | ||
| "End of interval must be strictly larger than the start.", |
Contributor
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| (tmin, tmax), | |
| "End of interval must be strictly larger than the start.", | |
| (tmin, tmax), "End of interval must be strictly larger than the start." |
| function event_marks(h::History, a, b) | ||
| imin = searchsortedfirst(h.times, a) | ||
| imax = searchsortedfirst(h.times, b) - 1 | ||
| return @view h.marks[imin: imax] |
Contributor
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| return @view h.marks[imin: imax] | |
| return @view h.marks[imin:imax] |
| function event_dims(h::History, a, b) | ||
| imin = searchsortedfirst(h.times, a) | ||
| imax = searchsortedfirst(h.times, b) - 1 | ||
| return @view h.dims[imin: imax] |
Contributor
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| return @view h.dims[imin: imax] | |
| return @view h.dims[imin:imax] |
Comment on lines
+266
to
+267
| nb_events(h::History{1}, a, b, ::Int) = nb_events(h, a ,b) | ||
| function nb_events(h::History{N}, a, b, d::Int) where {N} |
Contributor
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| nb_events(h::History{1}, a, b, ::Int) = nb_events(h, a ,b) | |
| function nb_events(h::History{N}, a, b, d::Int) where {N} | |
| nb_events(h::History{1}, a, b, ::Int) = nb_events(h, a, b) | |
| function nb_events(h::History{N}, a, b, d::Int) where {N} |
Comment on lines
+409
to
+410
| (tmin, tmax), | ||
| "End of interval must be strictly larger than the start.", |
Contributor
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| (tmin, tmax), | |
| "End of interval must be strictly larger than the start.", | |
| (tmin, tmax), "End of interval must be strictly larger than the start." |
| throw(ArgumentError("All event dimensions must lie between 1 and N")) | ||
| end | ||
| end | ||
| end No newline at end of file |
Contributor
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| end | |
| end | |
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
Collaborator
|
Edit: I just realized that the discussion about this PR is in Issue #73 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added the parameter
Nto history, indicating the number of marginal processes in the multivariate point process. Added methods to access the marginal histories and counts.Virtually no change in implementation was necessary for univariate processes to keep working as before.