Skip to content

Commit 956a805

Browse files
committed
propel comment
1 parent f8a7619 commit 956a805

File tree

2 files changed

+8
-17
lines changed

2 files changed

+8
-17
lines changed

src/judgeval/dataset/__init__.py

Lines changed: 4 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -153,21 +153,17 @@ def create(
153153
)
154154
judgeval_logger.info(f"Created dataset {name}")
155155

156-
dataset_instance = cls(
157-
name=name,
158-
project_name=project_name,
159-
examples=[],
160-
)
161-
dataset_instance.add_examples(examples, batch_size=batch_size)
162-
163156
if not isinstance(examples, list):
164157
examples = list(examples)
165158

166-
return cls(
159+
dataset = cls(
167160
name=name,
168161
project_name=project_name,
169162
examples=examples,
170163
)
164+
dataset.add_examples(examples, batch_size=batch_size)
165+
166+
return dataset
171167

172168
@classmethod
173169
def list(cls, project_name: str):

src/judgeval/v1/datasets/dataset_factory.py

Lines changed: 4 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -77,19 +77,14 @@ def create(
7777
)
7878
judgeval_logger.info(f"Created dataset {name}")
7979

80-
dataset = Dataset(
81-
name=name, project_name=project_name, examples=[], client=self._client
82-
)
83-
dataset.add_examples(examples, batch_size=batch_size)
8480
if not isinstance(examples, list):
8581
examples = list(examples)
8682

87-
return Dataset(
88-
name=name,
89-
project_name=project_name,
90-
examples=examples,
91-
client=self._client,
83+
dataset = Dataset(
84+
name=name, project_name=project_name, examples=examples, client=self._client
9285
)
86+
dataset.add_examples(examples, batch_size=batch_size)
87+
return dataset
9388

9489
def list(self, project_name: str) -> List[DatasetInfo]:
9590
datasets = self._client.datasets_pull_all_for_judgeval(

0 commit comments

Comments
 (0)