Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion src/judgeval/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -171,7 +171,14 @@ def upload_custom_scorer(
return False

except Exception as e:
# Don't log here - let the CLI handle error display
from judgeval.exceptions import JudgmentAPIError

# Handle duplicate scorer error
if isinstance(e, JudgmentAPIError) and e.status_code == 409:
error_msg = "Duplicate scorer detected. Use overwrite=True to replace the existing scorer"
judgeval_logger.error(error_msg)
raise ValueError(error_msg) from e
# Re-raise other exceptions
raise


Expand Down
10 changes: 5 additions & 5 deletions src/judgeval/cli.py
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@
from judgeval.logger import judgeval_logger
from judgeval import JudgmentClient
from judgeval.version import get_version
from judgeval.exceptions import JudgmentAPIError

load_dotenv()

Expand Down Expand Up @@ -59,11 +58,12 @@ def upload_scorer(

judgeval_logger.info("Custom scorer uploaded successfully!")
raise typer.Exit(0)
except ValueError as e:
# Handle errors from JudgmentClient (including duplicate scorer)
judgeval_logger.error(str(e))
raise typer.Exit(1)
except Exception as e:
if isinstance(e, JudgmentAPIError) and e.status_code == 409:
judgeval_logger.error("Duplicate scorer detected. Use --overwrite flag to replace the existing scorer")
raise typer.Exit(1)
# Re-raise other exceptions
# Re-raise unexpected exceptions
raise


Expand Down
2 changes: 1 addition & 1 deletion src/judgeval/tracer/constants.py
Original file line number Diff line number Diff line change
@@ -1 +1 @@
JUDGEVAL_TRACER_INSTRUMENTING_MODULE_NAME = "judgeval"
JUDGEVAL_TRACER_INSTRUMENTING_MODULE_NAME = "opentelemetry.instrumentation.judgeval"