Implementing domains as an interface #141
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Empty file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -2,7 +2,7 @@ | |
| iscompact(d::TypedEndpointsInterval{:closed,:closed}) = true | ||
| iscompact(d::TypedEndpointsInterval) = false | ||
|
|
||
| isinterval(d) = false | ||
| isinterval(d::AbstractInterval) = true | ||
|
|
||
| hash(d::AbstractInterval, h::UInt) = | ||
|
|
@@ -54,9 +54,9 @@ end | |
| boundary(d::AbstractInterval) = Point(leftendpoint(d)) ∪ Point(rightendpoint(d)) | ||
| corners(d::AbstractInterval) = [leftendpoint(d), rightendpoint(d)] | ||
|
|
||
| normal(d::AbstractInterval, x) = (abs(minimum(d)-x) < abs(maximum(d)-x)) ? -one(deltype(d)) : one(deltype(d)) | ||
|
|
||
| distance_to(d::AbstractInterval, x) = x ∈ d ? zero(deltype(d)) : min(abs(x-supremum(d)), abs(x-infimum(d))) | ||
|
|
||
| boundingbox(d::AbstractInterval) = d | ||
|
|
||
|
|
@@ -79,6 +79,10 @@ and `ChebyshevInterval`. | |
| abstract type FixedInterval{L,R,T} <: TypedEndpointsInterval{L,R,T} end | ||
| const ClosedFixedInterval{T} = FixedInterval{:closed,:closed,T} | ||
|
|
||
| convert(::Type{AbstractInterval{T}}, d::FixedInterval{L,R,T}) where {L,R,T} = d | ||
| convert(::Type{AbstractInterval{T}}, d::FixedInterval{L,R,S}) where {L,R,S,T} = | ||
| similardomain(d, T) | ||
|
|
||
| closure(d::AbstractInterval) = ClosedInterval(endpoints(d)...) | ||
| closure(d::ClosedInterval) = d | ||
|
|
||
|
|
@@ -244,8 +248,8 @@ function similar_interval(d::HalfLine{T,C}, a::S, b::S) where {T,S,C} | |
| HalfLine{promote_type(float(T),S),C}() | ||
| end | ||
|
|
||
| point_in_domain(d::NonnegativeRealLine) = zero(deltype(d)) | ||
|
There was a problem hiding this comment. Probably this name is clearer, but this is called a "choice function" in the Axiom of Choice so we could just call this There was a problem hiding this comment. Hmm, it would be good if There was a problem hiding this comment. Just add There was a problem hiding this comment.
There was a problem hiding this comment. the There was a problem hiding this comment. Okay, I'm renaming to |
||
| point_in_domain(d::PositiveRealLine) = one(deltype(d)) | ||
|
|
||
|
|
||
| "The negative halfline `(-∞,0]` or `(-∞,0)`, right-closed or right-open." | ||
|
|
@@ -276,8 +280,8 @@ function similar_interval(d::NegativeHalfLine{T,C}, a::S, b::S) where {S,T,C} | |
| NegativeHalfLine{promote_type(S,float(T)),C}() | ||
| end | ||
|
|
||
| point_in_domain(d::NegativeRealLine) = -one(deltype(d)) | ||
| point_in_domain(d::NonpositiveRealLine) = zero(deltype(d)) | ||
|
|
||
|
|
||
| "The real line `(-∞,∞)`." | ||
|
|
@@ -318,11 +322,11 @@ intersect(d1::FixedInterval, d2::FixedInterval) = intersectdomain(d1, d2) | |
|
|
||
| # Promotion to joint type T | ||
| uniondomain(d1::TypedEndpointsInterval, d2::TypedEndpointsInterval) = | ||
| uniondomain(promote_domains(d1,d2)...) | ||
| intersectdomain(d1::TypedEndpointsInterval, d2::TypedEndpointsInterval) = | ||
| intersectdomain(promote_domains(d1,d2)...) | ||
| setdiffdomain(d1::AbstractInterval, d2::AbstractInterval) = | ||
| setdiffdomain(promote_domains(d1,d2)...) | ||
|
|
||
|
|
||
|
|
||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's
unionbox1and belowintersectbox1?Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
unionbox(d1,d2)is a function of two arguments, which sometimes simplifies for certaind1(independently ofd2or for some possibilities ofd2). Similarly, it may simplify for certaind2. The call chain goes:unionbox(d1,d2)->unionbox1(d1,d2)->unionbox2(d1,d2)-> some_default_algorithmThe idea is that
unionbox1can dispatch safely (without ambiguity) solely on d1, and unionbox2 can dispatch on d2. I've used this pattern in many places and it works rather well. If a combination ofd1andd2is specific enough, then one can dispatch on it using just theunionboxfunction.