Skip to content

reorganize slightly and add FixedSizeBitArray #75

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

oscardssmith
Copy link
Member

This arguably should be 2 separate PRs, the first splits the code in this repo into files for better separation of concerns, while the 2nd (and only functional change) adds a new FixedSizeBitArray that is similar to a regular BitArray, but is fixed size, and makes sure that columns don't alias each-other (by giving each column it's own chunk). This slightly complicates indexing, but it makes lots of matrix operations a lot faster since you can broadcast views of the columns with each-other without worrying about columns clobbering each other.

Copy link

codecov bot commented Jan 4, 2025

Codecov Report

Attention: Patch coverage is 0% with 45 lines in your changes missing coverage. Please review.

Project coverage is 82.73%. Comparing base (810c0a0) to head (e00a970).

Files with missing lines Patch % Lines
src/FixedSizeBitArray.jl 0.00% 45 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main      #75       +/-   ##
===========================================
- Coverage   98.71%   82.73%   -15.98%     
===========================================
  Files           3        4        +1     
  Lines         233      278       +45     
===========================================
  Hits          230      230               
- Misses          3       48       +45     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nsajko
Copy link
Collaborator

nsajko commented Jan 4, 2025

This arguably should be 2 separate PRs

Why not split it up?

@oscardssmith
Copy link
Member Author

I probably will

@giordano
Copy link
Collaborator

giordano commented Jan 5, 2025

Some tests would be good now 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants