Skip to content

test: update github actions CI and run tests on LTS and pre #1002

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

franckgaga
Copy link
Member

@franckgaga franckgaga commented Jul 1, 2025

Trying to:

Since pre is not intended for normal julia users (i.e. non-package developers), I don't think it should impact the CI badge.

@franckgaga franckgaga marked this pull request as draft July 1, 2025 13:32
Copy link

codecov bot commented Jul 1, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.52%. Comparing base (7266a8c) to head (f188917).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1002   +/-   ##
=======================================
  Coverage   92.52%   92.52%           
=======================================
  Files          41       41           
  Lines        5096     5096           
=======================================
  Hits         4715     4715           
  Misses        381      381           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@franckgaga franckgaga marked this pull request as ready for review July 1, 2025 14:50
@franckgaga
Copy link
Member Author

@baggepinnen See above, I think it's a great improvement to be a bit less "extinguishing the fire" in the maintenance of the package XP

It seems the the failling tests on pre are legit bugs, do you agree ?

@franckgaga
Copy link
Member Author

So I'm pretty sure that it's a bug in Julia 1.12, not in this package.

See JuliaLang/julia#58866

@baggepinnen
Copy link
Member

The testing on pre has to be marked an allowed failure, otherwise a low-priority issue (issues with unreleased version of julia) may block the fixing of high priority issues. Testing on unreleased versions has always been very noisy, which you just found out that even pre-releases are, and I don't want such failures to prevent merging of unrelated PRs.

@@ -19,7 +19,7 @@ jobs:
permissions: # needed for julia-actions/cache to delete old caches
actions: write
contents: read
continue-on-error: ${{ matrix.version == 'pre' }} # the CI badge will still pass if 'pre' fails
continue-on-error: ${{ matrix.version == 'pre' || matrix.version == 'nightly' }} # the CI badge will still pass if 'pre' or 'nightly' fails
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is why I added this line. The failure on pre will be ignored in the final CI results.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that the icons below can be misleading since there is a big red X on pre. The CI badges will still be green howeve, as far as I know.

This is an issue with GitHub actions, the allow-failure setting does not exist for now actions/runner#2347

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Different behavior of MIMO system construction on Julia 1.12 Update test.yml with new github actions
2 participants