Skip to content

Commit 0ab689e

Browse files
authored
Preemptively support JSON 1.0 release (#2717)
* Preemptively support JSON 1.0 release As [noted](JuliaIO/JSON.jl#374 (comment)), the JSON 1.0 release is currently blocked on using Documenter due to the circular dependency of needing Documenter to build docs. The usage of JSON.jl in Documenter.jl is very vanilla, so this PR proposed "preemptive" support for JSON.jl 1.0 since the usage of JSON in Documenter is known to not rely on any breaking changes proposed.
1 parent b2f54cf commit 0ab689e

File tree

3 files changed

+6
-2
lines changed

3 files changed

+6
-2
lines changed

CHANGELOG.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
55

66
## Unreleased
77

8+
### Changed
9+
10+
* Add preemptive support for JSON.jl 1.0. ([#2717])
11+
812
### Fixed
913

1014
* Fixed an issue when building PDFs with local images on Windows. ([#2434])

Project.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ Downloads = "1.4"
3838
Git = "1"
3939
IOCapture = "0.2"
4040
InteractiveUtils = "1.6"
41-
JSON = "0.19, 0.20, 0.21"
41+
JSON = "0.19, 0.20, 0.21, 1"
4242
Logging = "1.6"
4343
Markdown = "1.6"
4444
MarkdownAST = "0.1.1"

src/deployconfig.jl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -512,7 +512,7 @@ function post_github_status(type::S, deploydocs_repo::S, sha::S, subfolder = not
512512
else
513513
error("unsupported type: $type")
514514
end
515-
push!(cmd.exec, "-d", sprint(JSON.print, json))
515+
push!(cmd.exec, "-d", JSON.json(json))
516516
push!(cmd.exec, "https://api.github.com/repos/$(owner)/$(repo)/statuses/$(sha)")
517517
# Run the command (silently)
518518
io = IOBuffer()

0 commit comments

Comments
 (0)