Skip to content

CoupledSDEs pretty printing #98

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

CoupledSDEs pretty printing #98

wants to merge 4 commits into from

Conversation

reykboerner
Copy link
Collaborator

See #97

@reykboerner
Copy link
Collaborator Author

@oameye do you have an idea why the additional_details(::CoupledSDEs) function in src/CoupledSDEs.jl does not take effect? And why CoupledSDEs.integ.f returns SDEFunction instead of the deterministic function f?

I can look further into it later but maybe you know the answer immediately.

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@oameye
Copy link
Member

oameye commented Jul 23, 2024

not sure how pretty printing work in julia. Don't you need to define show methods?

Re the SDEFunction: We remake the SDEProblem to multiple g with the noise_strength. Because SDEProblem has multiple methods (e.g., SDEProblem(f::SDEFunction, ...) and SDEProblem(f::Function, g::Function)), remaking g in SDEProblem was nontrivial. See SciML/SciMLBase.jl#735 for details.

sde_function = SDEFunction(prob.f, add_noise_strength(noise_strength, prob.g, IIP))
prob = SciMLBase.remake(prob; f=sde_function)

@oameye oameye marked this pull request as ready for review July 24, 2024 20:33
Update src/CoupledSDEs.jl

Co-Authored-By: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@oameye oameye linked an issue Jul 25, 2024 that may be closed by this pull request
@oameye
Copy link
Member

oameye commented Jul 27, 2024

@reykboerner Can you give you opinion about the pretty printing?

@oameye
Copy link
Member

oameye commented Jul 28, 2024

pretty printing is moved into DSB.jl. See JuliaDynamics/DynamicalSystemsBase.jl#212

@oameye oameye closed this Jul 28, 2024
@oameye oameye deleted the prettyprint branch January 6, 2025 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CoupledSDEs pretty printing
2 participants