Skip to content

Commit 1c44a77

Browse files
committed
simplify ODE test dependency
1 parent dd98da6 commit 1c44a77

File tree

3 files changed

+7
-16
lines changed

3 files changed

+7
-16
lines changed

src/core_systems/continuous_time_ode.jl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -141,7 +141,7 @@ set_state!(ds::CoupledODEs, u::AbstractArray) = (set_state!(ds.integ, u); ds)
141141
# so that `ds` is printed
142142
SciMLBase.step!(ds::CoupledODEs, args...) = (step!(ds.integ, args...); ds)
143143

144-
function SciMLBase.reinit!(ds::ContinuousTimeDynamicalSystem, u = initial_state(ds);
144+
function SciMLBase.reinit!(ds::ContinuousTimeDynamicalSystem, u::AbstractArray = initial_state(ds);
145145
p = current_parameters(ds), t0 = initial_time(ds), kw...
146146
)
147147
set_parameters!(ds, p)

test/Project.toml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,8 @@ DiffEqNoiseProcess = "77a26b50-5914-5dd7-bc55-306e6241c503"
33
DynamicalSystemsBase = "6e36e845-645a-534a-86f2-f5d4aa5a06b4"
44
LinearAlgebra = "37e2e46d-f89d-539d-b4ee-838fcccc9c8e"
55
ModelingToolkit = "961ee093-0014-501f-94e3-6117800e7a78"
6-
OrdinaryDiffEq = "1dea7af3-3e70-54e6-95c3-0bf5283fa5ed"
6+
OrdinaryDiffEqRosenbrock = "43230ef6-c299-4910-a778-202eb28ce4ce"
7+
OrdinaryDiffEqTsit5 = "b1df2697-797e-41e3-8120-5422d3b24e4a"
78
Statistics = "10745b16-79ce-11e8-11f9-7d13ad32a3b2"
89
StochasticDiffEq = "789caeaf-c7a9-5a7d-9973-96adeb23e2a0"
910
Test = "8dfed614-e22c-5e08-85e1-65c5234f0b40"

test/continuous.jl

Lines changed: 4 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
using DynamicalSystemsBase, Test
22

3-
using OrdinaryDiffEq: Vern9, ODEProblem, Rodas5, Tsit5
3+
using OrdinaryDiffEqTsit5: ODEProblem, Tsit5
4+
using OrdinaryDiffEqRosenbrock: Rodas5
45

56
include("test_system_function.jl")
67

@@ -25,14 +26,9 @@ p0 = [10, 28, 8/3]
2526

2627
lorenz_oop = CoupledODEs(lorenz_rule, u0, p0)
2728
lorenz_iip = CoupledODEs(ODEProblem(lorenz_rule_iip, copy(u0), (0.0, Inf), p0))
28-
lorenz_vern = CoupledODEs(lorenz_rule, u0, p0;
29-
diffeq = (alg = Vern9(), abstol = 1e-9, reltol = 1e-9)
30-
)
3129

32-
for (ds, iip) in zip((lorenz_oop, lorenz_iip, lorenz_vern), (false, true, false))
33-
34-
name = (ds === lorenz_vern) ? "lorvern" : "lorenz"
35-
@testset "$(name) IIP=$(iip)" begin
30+
for (ds, iip) in zip((lorenz_oop, lorenz_iip), (false, true))
31+
@testset "IIP=$(iip)" begin
3632
@test dynamic_rule(ds) == (iip ? lorenz_rule_iip : lorenz_rule)
3733
test_dynamical_system(ds, u0, p0; idt = false, iip=iip)
3834
end
@@ -42,12 +38,6 @@ end
4238
lorenz_oop = CoupledODEs(lorenz_rule, u0, p0)
4339
@test lorenz_oop.integ.alg isa Tsit5
4440

45-
lorenz_vern = CoupledODEs(lorenz_rule, u0, p0;
46-
diffeq = (alg = Vern9(), verbose = false, abstol = 1e-9, reltol = 1e-9)
47-
)
48-
@test lorenz_vern.integ.alg isa Vern9
49-
@test lorenz_vern.integ.opts.verbose == false
50-
5141
# also test ODEproblem creation
5242
prob = lorenz_vern.integ.sol.prob
5343

0 commit comments

Comments
 (0)