Skip to content

Order of arguments in set_parameter! is reverse of what is should be... :( #222

@Datseris

Description

@Datseris

set_state! and set_parameter! have different ordering. State has first the value then the index, while parameter has first the index then the value. First, these two should be consistent. Second, they should follow Julia base syntax which is:

setindex!(collection, value, key...)

Store the given value at the given key or index within a collection. The syntax a[i,j,...] = x is converted by the compiler to (setindex!(a, x, i, j, ...); x).

Unfortunately there is no way to fix this :( because the parameter values could have the same type as the index (such as integers) so there is no way to fix this without making a huge breaking change. :( :( :(

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions