-
Notifications
You must be signed in to change notification settings - Fork 71
Release 1.0 #728
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release 1.0 #728
Conversation
Can you give me a couple of days to check if Taylor-related packages are ok with these changes? Would there be a v0.23.1, or shall we jump directly to v1.0? |
Of course! 🙂 |
I think we should add Actually, one thought occurred to me: since If this is indeed a reasonable concern, then I suggest we replace the |
That's a good catch, it is in fact possible. julia> a = ExactReal[]
ExactReal[]
julia> push!(a, 1)
1-element Vector{ExactReal}:
ExactReal{Int64}(1) Thanksfully that julia> b = Interval[]
Interval[]
julia> push!(b, 1)
1-element Vector{Interval}:
[1.0, 1.0]_com_NG So yes, disabling the direct ExactReal constructor is a good idea. I think that the implementation of the julia> @interval exp(3) exp(10)
┌ Warning: invalid interval, NaI is returned
└ @ IntervalArithmetic ~/.julia/dev/IntervalArithmetic/src/intervals/construction.jl:437
┌ Warning: interval part of NaI
└ @ IntervalArithmetic ~/.julia/dev/IntervalArithmetic/src/intervals/construction.jl:273
┌ Warning: invalid interval, NaI is returned
└ @ IntervalArithmetic ~/.julia/dev/IntervalArithmetic/src/intervals/construction.jl:437
∅_ill
julia> @interval Float64 exp(3) exp(10)
[20.0855, 22026.5]_com I'm not sure what is going wrong in the first case. What did you do to Other than that, everything looks fine to me, I especially like the new |
Yes, I re-added the functions
Ok I have a commit, ready. I will push it now then.
Ah shoot. I'll try to give it an other try 😓 |
I think
For example: julia> @macroexpand @interval exp(3) exp(10)
:(IntervalArithmetic.interval(exp(IntervalArithmetic._atomic(Float64, 3)), exp(IntervalArithmetic._atomic(exp(3), 10)))) So this may not be very sharp in general. Here, |
Mhmm nightly is failing
It's probably nothing since the tests pass on 1.10, 1.11 🤷♂️ |
I agree that Therefore, everything now looks good to me, and this PR can be merged whenever @lbenet greenlights it (but no later than the 2nd of October, so it is released for my JuliaCon talk :D) |
Fully agree with both of you!
So far, my checks on the Taylor-related packages are, ok. So green lights on my side too. I propose to release IA v1.0, then tag a new version of IntervalRootFinding (so it works with IA v1.0), and I'll release patches on TaylorSeries and TaylorModels; the latter requires the new version of IntervalRootFinding... Congrats to all! |
I just restarted the tests of the failed jobs (nightly).... |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #728 +/- ##
==========================================
- Coverage 78.27% 77.89% -0.39%
==========================================
Files 31 31
Lines 2923 2922 -1
==========================================
- Hits 2288 2276 -12
- Misses 635 646 +11 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
5772366
to
9dfbead
Compare
Tests are passing with the next release candidate 1.12. |
congratulations for the release, thanks for the hard work 🚀 |
🥳