Strip whitespace from Pkg commands #1160
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This avoids a parsing error in Pkg with `] add Foo, Bar`.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1160 +/- ##
======================================
Coverage 9.90% 9.90%
======================================
Files 15 15
Lines 848 848
======================================
Hits 84 84
Misses 764 764 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
stevengj
approved these changes
May 17, 2025
|
Sounds good, though arguably Pkg parsing shouldn't be so brittle. |
|
Yeah, I opened an issue for it here: JuliaLang/Pkg.jl#4239 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This avoids a parsing error in Pkg with
] add Foo, Bar.Fixes #1095.