Skip to content

Strip whitespace from Pkg commands #1160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 17, 2025
Merged

Strip whitespace from Pkg commands #1160

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions docs/src/_changelog.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ Changelog](https://keepachangelog.com).
- The Julia major and minor version are no longer appended to a custom
`specname` in [`installkernel()`](@ref). The default `specname` that derives
from `name` and appends the Julia version remains unchanged ([#1154]).
- Fixed adding multiple packages in Pkg mode ([#1160]).

## [v1.27.0]

Expand Down
2 changes: 1 addition & 1 deletion src/execute_request.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@

# "] ..." cells are interpreted as pkg shell commands
if occursin(r"^\].*$", code)
code = "IJulia.do_pkg_cmd(\"" * escape_string(code[2:end]) * "\")"
code = "IJulia.do_pkg_cmd(\"" * escape_string(strip(code[2:end])) * "\")"

Check warning on line 65 in src/execute_request.jl

View check run for this annotation

Codecov / codecov/patch

src/execute_request.jl#L65 

Added line #L65 was not covered by tests
end

# a cell beginning with "? ..." is interpreted as a help request
Expand Down
Loading