add error that explains PackageSpec.repo is a private field

Author: IanButterworth

src/API.jl

@@ -1557,7 +1557,10 @@ end
 
 function handle_package_input!(pkg::PackageSpec)
     if pkg.path !== nothing && pkg.url !== nothing
-        pkgerror("`path` and `url` are conflicting specifications")
+        pkgerror("Conflicting `path` and `url` in PackageSpec")
+    end
+    if pkg.repo.source !== nothing || pkg.repo.rev !== nothing || pkg.repo.subdir !== nothing
+        pkgerror("`repo` is a private field of PackageSpec and should not be set directly")
     end
     pkg.repo = Types.GitRepo(rev = pkg.rev, source = pkg.url !== nothing ? pkg.url : pkg.path,
                          subdir = pkg.subdir)

src/Types.jl

@@ -92,7 +92,7 @@ mutable struct PackageSpec
     uuid::Union{Nothing,UUID}
     version::Union{Nothing,VersionTypes,String}
     tree_hash::Union{Nothing,SHA1}
-    repo::GitRepo
+    repo::GitRepo # private
     path::Union{Nothing,String}
     pinned::Bool
     # used for input only

test/new.jl

@@ -1831,6 +1831,8 @@ end
         Pkg.dependencies(exuuid) do pkg
             @test pkg.version > v"0.3.0"
         end
+
+        @test_throws PkgError("`repo` is a private field of PackageSpec and should not be set directly") Pkg.add([PackageSpec(;repo=LibGit2.GitRepo(url="someurl"))])
     end
 end
 
@@ -2069,7 +2071,7 @@ end
                 end
             end
         end
-    end    
+    end
 end
 
 #