Merge pull request #30 from fredrikekre/fe/iostream

Allow passing an IOStream to FileLogger.

Author: oxinabox

Project.toml

@@ -1,7 +1,7 @@
 name = "LoggingExtras"
 uuid = "e6f89c97-d47a-5376-807f-9c37f3926c36"
 authors = ["Lyndon White <oxinabox@ucc.asn.au>"]
-version = "0.4.0"
+version = "0.4.1"
 
 [compat]
 julia = "0.7, 1"

src/filelogger.jl

@@ -3,11 +3,14 @@ struct FileLogger <: AbstractLogger
     always_flush::Bool
 end
 
-function FileLogger(path; append=false, always_flush=true)
+function FileLogger(path; append=false, kwargs...)
     filehandle = open(path, append ? "a" : "w")
-    FileLogger(SimpleLogger(filehandle, BelowMinLevel), always_flush)
+    FileLogger(filehandle; kwargs...)
 end
 
+function FileLogger(filehandle::IOStream; always_flush=true)
+    FileLogger(SimpleLogger(filehandle, BelowMinLevel), always_flush)
+end
 
 function handle_message(filelogger::FileLogger, args...; kwargs...)
     handle_message(filelogger.logger, args...; kwargs...)

test/runtests.jl

@@ -33,16 +33,21 @@ end
 
 @testset "File" begin
     mktempdir() do dir
-        filepath = joinpath(dir, "log")
-        with_logger(FileLogger(filepath)) do
-            @info "first"
-            @warn "second"
-            @info "third"
+        for (filepath, sink) in [
+                (f = joinpath(dir, "log"); (f, f)), # Filepath
+                (f = joinpath(dir, "log_io"); (f, open(f, "w"))), # IOStream
+            ]
+            with_logger(FileLogger(sink)) do
+                @info "first"
+                @warn "second"
+                @info "third"
+            end
+            sink isa IOStream && close(sink)
+            logtext = read(filepath, String)
+            @test occursin("first", logtext)
+            @test occursin("second", logtext)
+            @test occursin("third", logtext)
         end
-        logtext = String(read(filepath))
-        @test occursin("first", logtext)
-        @test occursin("second", logtext)
-        @test occursin("third", logtext)
     end
 end