Skip to content

Add tests based on python's itertools #130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

natemcintosh
Copy link
Contributor

Feel free to ignore and close this PR without explanation.

The basic idea here is to test the Julia version against the python itertools.

Assumptions: python's itertools library is correct.

  • Benefits:
    • Can verify behavior for longer sequences. This could help find corner cases not explored in the current, smaller test set.
    • Greatly expands the test set with only a little code added to the repo.
  • Downsides:
    • If the algorithms are ever changed in such a way that the order of combinations/permutations produced changes, these tests will be useless, and will have to be removed.
    • Have to add PyCall as a test dependency. Could make CI take longer to run.

@codecov
Copy link

codecov bot commented Feb 1, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.97%. Comparing base (8a7a8ac) to head (a597eb0).
Report is 37 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #130   +/-   ##
=======================================
  Coverage   96.97%   96.97%           
=======================================
  Files           7        7           
  Lines         728      728           
=======================================
  Hits          706      706           
  Misses         22       22           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@natemcintosh
Copy link
Contributor Author

Looks like the failure on Julia 1.0 on windows is because PyCall failed to build. Not sure how to get around that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant