Skip to content

fix for FunctionConstructor UB #100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

fix for FunctionConstructor UB #100

wants to merge 3 commits into from

Conversation

vtjnash
Copy link
Contributor

@vtjnash vtjnash commented Mar 14, 2025

Similar to bugfix in #99

rafaqz
rafaqz approved these changes Mar 15, 2025
View reviewed changes
Copy link
Member

@rafaqz rafaqz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I think it was only like this because constructorof also followed this pattern of using parentmodule and nameof rather than .wrapper.

There may have been some concerns about using internals.

@aplavin aplavin mentioned this pull request Mar 15, 2025
Merged
@aplavin
Copy link
Member

aplavin commented Mar 15, 2025

Could you please rebase on master? CI was cleaned up there to avoid almost all spurious test failures.

@nsajko nsajko mentioned this pull request Jun 8, 2025
Merged
@nsajko
Copy link
Contributor

nsajko commented Jun 9, 2025

can be closed now, the changes are merged with #104

@aplavin aplavin closed this Jun 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rafaqz rafaqz rafaqz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vtjnash @aplavin @nsajko @rafaqz