Skip to content

fix for FunctionConstructor UB #100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

fix for FunctionConstructor UB #100

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e54ec7f
remove no-op UB from FunctionConstructor
vtjnash Mar 14, 2025
adac14c
fix
vtjnash Mar 14, 2025
b86ab4b
Update functions.jl
vtjnash Mar 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions src/functions.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,18 +8,17 @@ _isgensym(s::Symbol) = occursin("#", string(s))
@generated function (fc::FunctionConstructor{F})(args...) where F
isempty(args) && return Expr(:new, F)

T = getfield(parentmodule(F), nameof(F))
# We assume all gensym names are anonymous functions
_isgensym(nameof(F)) || return :($T(args...))
_isgensym(nameof(F)) || return :($F(args...))
# Define `new` for rebuilt function type that matches args
exp = Expr(:new, Expr(:curly, T, args...))
exp = Expr(:new, Expr(:curly, F, args...))
for i in 1:length(args)
push!(exp.args, :(args[$i]))
end
return exp
end

function ConstructionBase.constructorof(f::Type{F}) where F <: Function
FunctionConstructor{F}()
FunctionConstructor{Base.typename(F).wrapper}()
end

Loading