[Auditor] Use executables from Binutils_jll when possible
#1365
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giordano
commented
Feb 10, 2025
src/auditor/instruction_set.jl
Outdated
| objdump_cmd = "llvm-objdump -d $(basename(path))" | ||
| objdump_args = `-d $(basename(path))` | ||
| if Binutils_jll.is_available() && (Sys.islinux(platform) || Sys.isfreebsd(platform)) | ||
| run(ignorestatus(pipeline(`$(Binutils_jll.objdump()) $(objdump_args)`; stdout=output, stderr=devnull))) |
There was a problem hiding this comment.
Running objdump can take a long time, depending on the size of binary file. If this works, removing a lock acquisition here can be very beneficial for parallelism in presence of several object files to analyze.
giordano
force-pushed
the
mg/auditor-binutils
branch
6 times, most recently
from
b761a9e to
8c2134b
Compare
giordano
force-pushed
the
mg/auditor-binutils
branch
from
8c2134b to
50162dd
Compare
Sadly it doesn't seem to be working.
giordano
force-pushed
the
mg/auditor-binutils
branch
from
0e05549 to
1c2ce25
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.