Skip to content

Commit 574320e

Browse files
authored
[Platforms] Restore previous compilation flags for base armv7l architecture (#242)
Using only `-mcpu=generic-armv7-a` causes an error in the assembler with GCC 5: ```console % julia --compile=min -e 'using BinaryBuilderBase; BinaryBuilderBase.runshell(Platform("armv7l", "linux"); preferred_gcc_version=v"5")' sandbox:${WORKSPACE} # echo 'int main(){}' | /opt/arm-linux-gnueabihf/bin/arm-linux-gnueabihf-gcc -x c - -mcpu=generic-armv7-a Assembler messages: Error: unknown cpu `generic-armv7-a' Error: unrecognized option -mcpu=generic-armv7-a ``` We may have to revise how GCC is compiled for this platform, but this is for another day.
1 parent 141ab97 commit 574320e

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

Project.toml

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
name = "BinaryBuilderBase"
22
uuid = "7f725544-6523-48cd-82d1-3fa08ff4056e"
33
authors = ["Elliot Saba <staticfloat@gmail.com>"]
4-
version = "1.10.0"
4+
version = "1.10.1"
55

66
[deps]
77
CodecZlib = "944b1d66-785c-5afd-91f1-9de20f533193"

src/Platforms.jl

+1-1
Original file line numberDiff line numberDiff line change
@@ -110,7 +110,7 @@ const ARCHITECTURE_FLAGS = Dict(
110110
),
111111
"armv7l" => OrderedDict(
112112
# Base armv7l architecture, with the most basic of FPU's
113-
"armv7l" => ["-mcpu=generic-armv7-a", "-mfpu=vfpv3", "-mfloat-abi=hard"],
113+
"armv7l" => ["-march=armv7-a", "-mtune=generic-armv7-a", "-mfpu=vfpv3", "-mfloat-abi=hard"],
114114
# armv7l plus NEON and vfpv4, (Raspberry Pi 2B+, RK3328, most boards Elliot has access to)
115115
"neonvfpv4" => ["-mcpu=cortex-a53", "-mfpu=neon-vfpv4", "-mfloat-abi=hard"],
116116
),

0 commit comments

Comments
 (0)