-
Notifications
You must be signed in to change notification settings - Fork 33
Implement preliminary OCaml support #425
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 16 commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
2d9be45
Implement OCaml compiler support
topolarity a126db9
Use `aarch64-apple-darwin20` / `x86_64-apple-darwin14` for shards
topolarity 486d92c
Bump the GCC version when using OCaml.
maleadt d893a37
Add additional OCaml wrappers.
maleadt 0bf0466
Update artifacts.
maleadt d70b1c0
Fix Darwin shards.
maleadt d1531ab
Bump the used GCC version.
maleadt e3361c6
Also mount a host shard when requesting OCaml.
maleadt 6dfed70
Update list of wrappers.
maleadt f238346
Also generate wrappers for the host toolchain.
maleadt 4da0a1e
Set OCAMLLIB in the environment.
maleadt db33683
Regenerate OCaml 5.3, remove 5.4.
maleadt dea1d05
Bump RootFS to include OCaml hello_world test.
maleadt 6006091
Don't overwrite symlinks.
maleadt 6abf099
Define OCAMLC env var for test suite.
maleadt dd70539
Fix OCaml version in tests.
maleadt e17ce1b
Test for output.
maleadt 6358335
Bump version.
maleadt File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So, I think this is ok, but I wanted to point out that we already do some shenanigans in
gcc_version
atBinaryBuilderBase.jl/src/Rootfs.jl
Lines 447 to 538 in dd70539