Skip to content

SoapySDR: Bump to build for new platforms. #10846

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 28, 2025
Merged

SoapySDR: Bump to build for new platforms. #10846

merged 1 commit into from
Mar 28, 2025

Conversation

maleadt
Copy link
Contributor

@maleadt maleadt commented Mar 28, 2025

No description provided.

@maleadt maleadt merged commit 657b7fe into master Mar 28, 2025
33 checks passed
@maleadt maleadt deleted the tb/soapysdr branch March 28, 2025 18:44
@imciner2
Copy link
Member

This really should have had a version number change, because the last build of this JLL was before we bumped the version of JLLWrappers, so this build now has a compat on it for 1.7.0 instead of 1.2.0.

@maleadt
Copy link
Contributor Author

maleadt commented Mar 30, 2025

this build now has a compat on it for 1.7.0 instead of 1.2.0

Why is that a problem?

It seemed worse to me to diverge from upstream versioning just because of some internal Pkg restriction.

@imciner2
Copy link
Member

Why is that a problem?

There was a large discussion on Slack about this at the time the RISC-V builds were starting, because getting RISC-V support required this bump (JuliaPackaging/BinaryBuilder.jl#1357) and it basically boiled down to the fact this will cause a change in the environment when there was no associated version bump. This led to a large PR to fix it in the general registry JuliaRegistries/General#122129, and since then we have always required the version bump on a package that hasn't had one since that PR 1357 was released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants