[OCaml] Add Windows / macOS pre-built binaries #11124
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We usually target the generic ISAs, see https://github.com/JuliaPackaging/BinaryBuilderBase.jl/blob/45acaa5c78a091ef75e5daa5de7a8676600509a5/src/Platforms.jl#L128 and https://github.com/JuliaPackaging/BinaryBuilderBase.jl/blob/45acaa5c78a091ef75e5daa5de7a8676600509a5/src/Platforms.jl#L150 for the flags we use. |
topolarity
force-pushed
the
ct/ocaml-binaries
branch
3 times, most recently
from
b43ff55 to
3ede0a3
Compare
|
Looks like the flags didn't make it a few spots in the build system. Let me try again... |
topolarity
force-pushed
the
ct/ocaml-binaries
branch
from
3ede0a3 to
6145f97
Compare
|
That was an adventure... JuliaPackaging/BinaryBuilder.jl#1380 |
|
is this good to go? |
|
I still locally get some warnings: but assuming those are benign, this is good to go |
|
If those are system libraries provided by Windows, we can skip them at https://github.com/JuliaPackaging/BinaryBuilder.jl/blob/2a5e7117be9ade099cd1092e7a444bdcffc37500/src/auditor/dynamic_linkage.jl#L299-L349 |
|
Looks like they are, yeah: There are a few more: Should we add them all? |
|
Yes, thanks! |
|
The macOS builds reference absolute paths on your machine: |
|
The zstd feature must have gotten auto-enabled (since It's not required (and our other builds don't have it), so let me disable it real quick. |
OCaml's build system requires executing host artifacts on the build machine (and we need the patches for relocatability so no publicly distributed binaries work for us either)
topolarity
force-pushed
the
ct/ocaml-binaries
branch
from
6145f97 to
9c0ebaf
Compare
|
Alright, should be good to go now! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Locally I'm hitting:
If you know the appropriate
-mtuneorCFLAGS, I'll be happy to re-build to get a baseline-compatible binary