In make_chi, introspect J_T to determine default via
#90
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `via=:tau` option for `make_chi` requires that `J_T` takes a `tau` keyword argument. For the default "automatic" keyword for `via`, this should be checked explicitly via introspection. Otherwise, the naive definition of a `J_T` function by a user that does not use `tau` even though the functional is defined in terms of target states leads to a hard-to-understand error.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #90 +/- ##
========================================
- Coverage 88.2% 88.0% -0.2%
========================================
Files 19 19
Lines 1013 1053 +40
========================================
+ Hits 893 926 +33
- Misses 120 127 +7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
via=:tauoption formake_chirequires thatJ_Ttakes ataukeyword argument. For the default "automatic" keyword forvia, this should be checked explicitly via introspection. Otherwise, the naive definition of aJ_Tfunction by a user that does not usetaueven though the functional is defined in terms of target states leads to a hard-to-understand error.