better API names

Author: dehann

src/CloudGraphsDFG/services/CommonFunctions.jl

@@ -179,7 +179,7 @@ function _structToNeo4jProps(inst::Union{User, Robot, Session, PVND, N, APPE, AB
             if fieldname == :solverData
                 fnctype = getSolverData(inst).fnc.usrfnc!
                 try
-                    packtype = convert(PackedInferenceType, fnctype)
+                    packtype = convertPackedType(fnctype)
                     packed = convert(PackedFunctionNodeData{packtype}, getSolverData(inst))
                     packedJson = JSON2.write(packed)
                     val = "\"$(replace(packedJson, "\"" => "\\\""))\"" # Escape slashes too

src/Common.jl

@@ -4,8 +4,8 @@ _getmodule(t::T) where T = T.name.module
 _getname(t::T) where T = T.name.name
 
 
-Base.convert(::Type{<:PackedInferenceType}, t::Union{T, Type{T}}) where {T <: FunctorInferenceType} = getfield(_getmodule(t), Symbol("Packed$(_getname(t))"))
-Base.convert(::Type{<:FunctorInferenceType}, ::Type{PT}) where {PT <: PackedInferenceType} = getfield(PT.name.module, Symbol(string(PT.name.name)[7:end]))
+convertPackedType(t::Union{T, Type{T}}) where {T <: FunctorInferenceType} = getfield(_getmodule(t), Symbol("Packed$(_getname(t))"))
+convertStructType(::Type{PT}) where {PT <: PackedInferenceType} = getfield(PT.name.module, Symbol(string(PT.name.name)[7:end]))
 
 
 ##==============================================================================

src/DistributedFactorGraphs.jl

@@ -200,6 +200,9 @@ export getFactorType, getFactorFunction
 # Node Data
 export mergeVariableData!, mergeGraphVariableData!
 
+# Serialization type conversion
+export convertPackedType, convertStructType
+
 ##------------------------------------------------------------------------------
 ## Other utility functions
 ##------------------------------------------------------------------------------

src/services/Serialization.jl

@@ -238,7 +238,7 @@ function packFactor(dfg::G, f::DFGFactor)::Dict{String, Any} where G <: Abstract
     # Pack the node data
     fnctype = getSolverData(f).fnc.usrfnc!
     try
-        packtype = convert(PackedInferenceType, fnctype)
+        packtype = convertPackedType(fnctype)
         packed = convert(PackedFunctionNodeData{packtype}, getSolverData(f))
         props["data"] = JSON2.write(packed)
     catch ex
@@ -259,7 +259,7 @@ end
 function decodePackedType(::Type{T}, packeddata::GenericFunctionNodeData{PT}) where {T<:FactorOperationalMemory, PT}
   # usrtyp = convert(FunctorInferenceType, packeddata.fnc)
   # Also look at parentmodule
-  usrtyp = convert(FunctorInferenceType, PT)
+  usrtyp = convertStructType(PT)
   fulltype = DFG.FunctionNodeData{T{usrtyp}}
   factordata = convert(fulltype, packeddata)
   return factordata