Skip to content

Commit 7d55fde

Browse files
authored
Update needsahome.jl
1 parent f617156 commit 7d55fde

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

src/needsahome.jl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ variable labels `syms::Vector{Symbols}`.
1111
1212
SamC: Can we not just use _copyIntoGraph! for this? Looks like a small refactor to make it work.
1313
Will paste in as-is for now and we can figure it out as we go.
14-
DF: Absolutely agree that subgraph functions should use `DFG._copyIntoGraph!` as a single dependency in the code base. There have been a repeated new rewrites of IIF.buildSubGraphFromLabels (basic wrapper is fine) but nominal should be to NOT duplicate DFG functionality in IIF -- rather use/improve the existing features in DFG. FYI, I have repeatedly refactored this function over and over to use DFG properly but somehow this (add/delete/Variable/Factor) version keeps coming back without using `_copyIntoGraph`!!??? See my latest effort commented out below `buildSubgraphFromLabels!_SPECIAL` ... sigh.
14+
DF: Absolutely agree that subgraph functions should use `DFG._copyIntoGraph!` as a single dependency in the code base. There have been a repeated new rewrites of IIF.buildSubGraphFromLabels (basic wrapper is fine) but nominal should be to NOT duplicate DFG functionality in IIF -- rather use/improve the existing features in DFG. FYI, I have repeatedly refactored this function over and over to use DFG properly but somehow this (add/delete/Variable/Factor) version keeps coming back without using `_copyIntoGraph`!!??? See latest effort commented out below `buildSubgraphFromLabels!_SPECIAL`...
1515
1616
Notes
1717
- Slighly messy internals, but gets the job done -- some room for performance improvement.

0 commit comments

Comments
 (0)