Merge pull request #1013 from JuliaRobotics/23Q2/enh/fixesand212

fix unpackFactor for b64

Author: dehann

Project.toml

@@ -1,6 +1,6 @@
 name = "DistributedFactorGraphs"
 uuid = "b5cc3c7e-6572-11e9-2517-99fb8daf2f04"
-version = "0.21.1"
+version = "0.21.2"
 
 [deps]
 Base64 = "2a0f44e3-6c83-55bd-87e4-b1978d98bd5f"

src/services/DFGVariable.jl

@@ -425,7 +425,7 @@ Retrieve solver data structure stored in a variable.
 """
 function getSolverData(v::DFGVariable, key::Symbol=:default)
     #TODO this does not fit in with some of the other error behaviour. but its used so added @error
-    vnd =  haskey(v.solverDataDict, key) ? v.solverDataDict[key] : (@error "Variable $(getLabel(v)) does not have solver data $(key)"; nothing)
+    vnd =  haskey(getSolverDataDict(v), key) ? getSolverDataDict(v)[key] : (@error "Variable $(getLabel(v)) does not have solver data $(key)"; nothing)
     return vnd
 end
 

src/services/Serialization.jl

@@ -267,7 +267,13 @@ end
 function fncStringToData(packtype::Type{<:AbstractPackedFactor}, data::String)
 
     # Read string as JSON object to use as kwargs
-    fncData = JSON3.read(data)
+    fncData = JSON3.read(
+        if data[1] == '{'
+            data
+        else
+            String(base64decode(data))
+        end
+    )
     packT = packtype(;fncData.fnc...)
 
     packed = GenericFunctionNodeData{packtype}(