Skip to content

Commit 86e09ab

Browse files
committed
breaking change, AbstractRelative
1 parent 1426517 commit 86e09ab

File tree

3 files changed

+19
-3
lines changed

3 files changed

+19
-3
lines changed

src/Deprecated.jl

Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -125,3 +125,18 @@ function updateVariableSolverData!(dfg::AbstractDFG,
125125
Base.depwarn("updateVariableSolverData! argument verbose is deprecated in favor of keyword argument `warn_if_absent`, see #643", :updateVariableSolverData!)
126126
updateVariableSolverData!(dfg, variablekey, vnd, solveKey, useCopy, fields; warn_if_absent = verbose)
127127
end
128+
129+
130+
##==============================================================================
131+
## Deprecated in v0.11 Remove in the v0.12 cycle
132+
##==============================================================================
133+
134+
export AbstractRelativeFactor, AbstractRelativeFactorMinimize
135+
136+
@warn("BREAKING CHANGE v0.12: deprecating AbstractRelativeFactor, use AbstractRelativeRoots instead")
137+
@warn("BREAKING CHANGE v0.12: deprecating AbstractRelativeFactorMinimize, use AbstractRelativeMinimize instead")
138+
139+
const AbstractRelativeFactor = AbstractRelativeRoots
140+
const AbstractRelativeFactorMinimize = AbstractRelativeMinimize
141+
142+

src/DistributedFactorGraphs.jl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -190,7 +190,7 @@ export addData!
190190
# Factor Data
191191
export GenericFunctionNodeData, PackedFunctionNodeData, FunctionNodeData
192192
export FunctorInferenceType, PackedInferenceType
193-
export AbstractPrior, AbstractRelativeFactor, AbstractRelativeFactorMinimize
193+
export AbstractPrior, AbstractRelative, AbstractRelativeRoots, AbstractRelativeMinimize
194194
export FactorOperationalMemory
195195

196196
# accessors

src/entities/DFGFactor.jl

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,8 +13,9 @@ abstract type FactorOperationalMemory <: Function end
1313
# abstract type ConvolutionObject <: FactorOperationalMemory end
1414

1515
abstract type AbstractPrior <: FunctorInferenceType end
16-
abstract type AbstractRelativeFactor <: FunctorInferenceType end
17-
abstract type AbstractRelativeFactorMinimize <: FunctorInferenceType end
16+
abstract type AbstractRelative <: FunctorInferenceType end
17+
abstract type AbstractRelativeRoots <: AbstractRelative end
18+
abstract type AbstractRelativeMinimize <: AbstractRelative end
1819

1920
##==============================================================================
2021
## GenericFunctionNodeData

0 commit comments

Comments
 (0)