Skip to content

Commit c07421b

Browse files
committed
subgraph comment
1 parent b718730 commit c07421b

File tree

1 file changed

+2
-0
lines changed

1 file changed

+2
-0
lines changed

src/needsahome.jl

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,10 +11,12 @@ variable labels `syms::Vector{Symbols}`.
1111
1212
SamC: Can we not just use _copyIntoGraph! for this? Looks like a small refactor to make it work.
1313
Will paste in as-is for now and we can figure it out as we go.
14+
DF: Absolutely agree that subgraph functions should use `DFG._copyIntoGraph!` as a single dependency in the code base. There have been a repeated new rewrites of IIF.buildSubGraphFromLabels (basic wrapper is fine) but nominal should be to NOT duplicate DFG functionality in IIF -- rather use/improve the existing features in DFG. FYI, I have repeatedly refactored this function over and over to use DFG properly but somehow this (add/delete/Variable/Factor) version keeps coming back without using `_copyIntoGraph`!!??? See my latest effort commented out below `buildSubgraphFromLabels!_SPECIAL` ... sigh.
1415
1516
Notes
1617
- Slighly messy internals, but gets the job done -- some room for performance improvement.
1718
- Defaults to GraphDFG, but likely to change to LightDFG in future.
19+
- since DFG v0.6 LightDFG is the default.
1820
1921
DevNotes
2022
- TODO: still needs to be consolidated with `DFG._copyIntoGraph`

0 commit comments

Comments
 (0)