More DFGv1 cleanups and checks and Blobstore updates #1159
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #1159 +/- ##
===========================================
- Coverage 72.52% 72.39% -0.14%
===========================================
Files 29 29
Lines 2428 2427 -1
===========================================
- Hits 1761 1757 -4
- Misses 667 670 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -1074,7 +1042,7 @@ function copyGraph!( | |||
| @showprogress desc = "copy variables" enabled = showprogress for variable in | |||
| sourceVariables | |||
| variableCopy = deepcopyNodes ? deepcopy(variable) : variable | |||
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| variableCopy = deepcopyNodes ? deepcopy(variable) : variable | |
| variableCopy = deepcopyNodes ? deepcopy(variable) : variable |
| @@ -792,26 +784,10 @@ function VSDTestBlock!(fg, v1) | |||
| @test mergeVariableState!(fg, :a, vnd) == 1 | |||
|
|
|||
| # Bulk copy update x0 | |||
| @test updateVariableSolverData!(fg, [v1], :default) == nothing | |||
| @test DFG.copytoVariableState!(fg, v1.label, :default, getVariableState(fg, v1.label, :default)) == 1 | |||
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| @test DFG.copytoVariableState!(fg, v1.label, :default, getVariableState(fg, v1.label, :default)) == 1 | |
| @test DFG.copytoVariableState!( | |
| fg, | |
| v1.label, | |
| :default, | |
| getVariableState(fg, v1.label, :default), | |
| ) == 1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.