Skip to content

Standardize more types, filters, and more cleanup #1163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Jul 16, 2025

Conversation

Affie
Copy link
Member

@Affie Affie commented Jul 15, 2025

No description provided.

@Affie Affie added this to the v0.28.0 milestone Jul 15, 2025
@Affie Affie self-assigned this Jul 15, 2025
Copy link

codecov bot commented Jul 15, 2025

Codecov Report

Attention: Patch coverage is 80.98160% with 62 lines in your changes missing coverage. Please review.

Project coverage is 72.08%. Comparing base (e8b1286) to head (8c150d6).
Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
src/Deprecated.jl 32.35% 23 Missing ⚠️
src/services/AbstractDFG.jl 85.50% 10 Missing ⚠️
src/services/DFGVariable.jl 87.50% 8 Missing ⚠️
src/entities/DFGVariable.jl 73.33% 4 Missing ⚠️
src/services/Serialization.jl 66.66% 4 Missing ⚠️
src/services/CommonAccessors.jl 70.00% 3 Missing ⚠️
src/services/DFGFactor.jl 40.00% 3 Missing ⚠️
src/GraphsDFG/services/GraphsDFG.jl 95.74% 2 Missing ⚠️
src/DataBlobs/services/BlobEntry.jl 90.00% 1 Missing ⚠️
src/FileDFG/services/FileDFG.jl 85.71% 1 Missing ⚠️
... and 3 more
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1163      +/-   ##
===========================================
- Coverage    72.39%   72.08%   -0.31%     
===========================================
  Files           29       29              
  Lines         2427     2411      -16     
===========================================
- Hits          1757     1738      -19     
- Misses         670      673       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Affie Affie mentioned this pull request Jul 16, 2025
@Affie Affie marked this pull request as ready for review July 16, 2025 14:27
@Affie Affie merged commit 3201b6c into develop Jul 16, 2025
6 checks passed
@Affie Affie deleted the enh/abstrtypes_and_cleanup branch July 16, 2025 14:27
@Affie Affie linked an issue Jul 16, 2025 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Standardize Abstract types
1 participant