Skip to content

Commit ab471bb

Browse files
committed
restore reverse
1 parent 4150b95 commit ab471bb

File tree

2 files changed

+5
-2
lines changed

2 files changed

+5
-2
lines changed

src/FactorGraph01.jl

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1095,6 +1095,7 @@ function getEliminationOrder(dfg::G; ordering::Symbol=:qr, solvable::Int=1) wher
10951095
end
10961096

10971097
# Return the variable ordering that we should use for the Bayes map
1098+
# reverse order checked in #475 and #499
10981099
return permuteds[p] |> reverse
10991100
end
11001101

src/JunctionTree.jl

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -205,14 +205,16 @@ end
205205
206206
Build the whole tree in batch format.
207207
"""
208-
function buildTree!(tree::BayesTree, dfg::G, elimorder::Array{Symbol,1}) where G <: AbstractDFG
209-
revorder = reverse(elimorder,dims=1) # flipdim(p, 1)
208+
function buildTree!(tree::BayesTree, dfg::AbstractDFG, elimorder::Array{Symbol,1})
209+
revorder = reverse(elimorder,dims=1) # flipdim(p, 1), fixing #499
210210
# prevVar = 0
211211
for var in revorder
212212
@info "Adding $var to tree..."
213213
newPotential(tree, dfg, var, elimorder)
214214
prevVar = var
215215
end
216+
217+
return tree
216218
end
217219

218220
"""

0 commit comments

Comments
 (0)