Splitting out IIFTypes as a separate module. #1872
Open
+415
−397
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Affie
force-pushed
the
refac/types
branch
2 times, most recently
from
460f19f to
8026e4a
Compare
Affie
changed the title
Affie
force-pushed
the
refac/types
branch
2 times, most recently
from
d70d299 to
b2da44e
Compare
|
Because mixtures do not follow the standard pattern, we need to resolve #1420 before IIFTypes can be fully supported/implemented. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr should split out:
Serialization is pack/unpack only
IIFTypes should be ready to register as subproject (won't register yet)
DFG + IIFTypes [later RoMETypes] should be able to pack/unpack variables and factors without IIF.