Small Fix #120
Merged
Small Fix #120
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bug Fix: exit if too many unsuccessful iterations in a row
tmigot
requested changes
Jul 24, 2024
| @@ -148,8 +148,8 @@ function SolverCore.solve!( | |||
| [Int64, T, T, T, String, T, T, T], | |||
| ) | |||
| verbose > 0 && @info log_row(Any[iter, ft, norm_∇f, 0.0, "First iteration", α]) | |||
|
|
|||
| callback(nlp, solver, stats) | |||
There was a problem hiding this comment.
You can actually access the nlp_at_x by solver.stp.nlp_at_x , so I prefer callback(nlp, solver, stats)
|
I still am not seeing the remote/main having these changes. It would be nice if this was merged into main, so I don't have to dev this repo anymore. Thanks again. Nic |
|
Hi @nrummel ! As you can see here, I made some comments that you need to adress before the PR is being merged. |
|
Thanks for doing this. Apologies, I have been pushing this small task down my to do list for a while now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello JSO Team,
I wanted to use your ARCqK algorithm in my work, but it was cycling when my cost function was misbehaving. I think the algorithm is supposed to exit when there are too many unsuccessful iterations in a row, but instead it got stuck in an infinite loop until time controls hit.
Also, I want to pass the nlp_at_x the callback so that I have access to the current x at each iteration.
Finally, I think the counter for very successful iterations was in the wrong place.
Thanks for making your algorithm available in Julia.
Nic