Skip to content

Add an option history for all Krylov methods #274

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 17, 2021

Conversation

amontoison
Copy link
Member

@codecov
Copy link

codecov bot commented Mar 16, 2021

Codecov Report

Merging #274 (edf1a68) into master (bd040c1) will decrease coverage by 0.22%.
The diff coverage is 95.55%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #274      +/-   ##
==========================================
- Coverage   97.25%   97.02%   -0.23%     
==========================================
  Files          32       32              
  Lines        3495     3495              
==========================================
- Hits         3399     3391       -8     
- Misses         96      104       +8     
Impacted Files Coverage Δ
src/minres.jl 100.00% <ø> (ø)
src/symmlq.jl 97.83% <71.42%> (ø)
src/bicgstab.jl 100.00% <100.00%> (ø)
src/bilq.jl 100.00% <100.00%> (ø)
src/bilqr.jl 100.00% <100.00%> (ø)
src/cg.jl 100.00% <100.00%> (ø)
src/cg_lanczos.jl 100.00% <100.00%> (ø)
src/cgls.jl 100.00% <100.00%> (ø)
src/cgne.jl 100.00% <100.00%> (ø)
src/cgs.jl 100.00% <100.00%> (ø)
... and 20 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bd040c1...edf1a68. Read the comment docs.

@dpo
Copy link
Member

dpo commented Mar 17, 2021

Is this supposed to be merged before #269 ?

@amontoison
Copy link
Member Author

amontoison commented Mar 17, 2021

Yes, I want to do a release before we break everything with #269 and #271 .

@amontoison amontoison merged commit bd42842 into JuliaSmoothOptimizers:master Mar 17, 2021
@amontoison amontoison deleted the history branch August 4, 2021 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a boolean option history to store or not the residual and Aresidual norms history
2 participants