Skip to content

Update tolerance for allocations tests #310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 24, 2021

Conversation

amontoison
Copy link
Member

We can reduce the tolerance thanks to #274.

@github-actions
Copy link
Contributor

Package name latest stable
CaNNOLeS.jl
DCI.jl
JSOSolvers.jl
Percival.jl

@codecov
Copy link

codecov bot commented May 23, 2021

Codecov Report

Merging #310 (5091e31) into master (632a37e) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 5091e31 differs from pull request most recent head 3ac1cc6. Consider uploading reports for the commit 3ac1cc6 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master     #310   +/-   ##
=======================================
  Coverage   96.23%   96.23%           
=======================================
  Files          33       33           
  Lines        4086     4092    +6     
=======================================
+ Hits         3932     3938    +6     
  Misses        154      154           
Impacted Files Coverage Δ
src/variants.jl 55.55% <ø> (ø)
src/krylov_solvers.jl 100.00% <100.00%> (ø)
src/symmlq.jl 97.91% <100.00%> (+0.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f777bfb...3ac1cc6. Read the comment docs.

@amontoison amontoison changed the title Use 1% of tolerance for memory allocations Update tolerance for allocations tests May 23, 2021
@github-actions
Copy link
Contributor

Package name latest stable
CaNNOLeS.jl
DCI.jl
JSOSolvers.jl
Percival.jl

@amontoison amontoison merged commit 15104ad into JuliaSmoothOptimizers:master May 24, 2021
@github-actions
Copy link
Contributor

Package name latest stable
CaNNOLeS.jl
DCI.jl
JSOSolvers.jl
Percival.jl

@amontoison amontoison deleted the allocs branch August 4, 2021 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant