-
Notifications
You must be signed in to change notification settings - Fork 60
implementation Line Search with Negative Curvature Detection with direction for CR #985
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
implementation Line Search with Negative Curvature Detection with direction for CR #985
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #985 +/- ##
==========================================
+ Coverage 94.68% 97.48% +2.80%
==========================================
Files 45 49 +4
Lines 8027 9347 +1320
==========================================
+ Hits 7600 9112 +1512
+ Misses 427 235 -192 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
@dpo I’ve updated the PR. I introduced The idea is that we can detect 0, 1, or 2 negative directions. Let me know what you think! |
Co-authored-by: Dominique <dominique.orban@gmail.com>
bf3d347
to
71ccf69
Compare
Co-authored-by: Dominique <dominique.orban@gmail.com>
Co-authored-by: Dominique <dominique.orban@gmail.com>
Co-authored-by: Dominique <dominique.orban@gmail.com>
Co-authored-by: Dominique <dominique.orban@gmail.com>
Co-authored-by: Dominique <dominique.orban@gmail.com>
Co-authored-by: Dominique <dominique.orban@gmail.com>
Co-authored-by: Dominique <dominique.orban@gmail.com>
added npc_dir logic for when |
The algorithm adapts its behavior upon detecting nonpositive curvature:
This modification ensures that the CR algorithm can be effectively utilized within inexact Newton methods that employ a linesearch strategy.