Skip to content

Conversation

@MaxenceGollier
Copy link
Collaborator

@MaxenceGollier MaxenceGollier requested a review from dpo March 3, 2025 18:21
@MaxenceGollier
Copy link
Collaborator Author

I think we can merge now @dpo

@dpo
Copy link
Member

dpo commented Mar 25, 2025

@MaxenceGollier In #178 (comment), we also talked abour replacing νInv everywhere.

@MaxenceGollier
Copy link
Collaborator Author

Done @dpo, the implementation of LMTR is confusing in my opinion, please review my changes before merging.

Copy link
Member

@dpo dpo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much better. Thank @MaxenceGollier ! Just one final improvement.

@MaxenceGollier
Copy link
Collaborator Author

Can we merge now ? @dpo

@dpo
Copy link
Member

dpo commented Apr 7, 2025

Thank you @MaxenceGollier. Could you please rebase? All the workflows fail because some workflow dependencies are outdated. I just merged an update.

Also, please open a PR to print ν instead of 1/ν in the other solvers. Thanks!

@codecov
Copy link

codecov bot commented Apr 9, 2025

Codecov Report

Attention: Patch coverage is 96.15385% with 1 line in your changes missing coverage. Please review.

Project coverage is 58.22%. Comparing base (e0f214d) to head (35300c3).
Report is 79 commits behind head on master.

Files with missing lines Patch % Lines
src/TRDH_alg.jl 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #180      +/-   ##
==========================================
- Coverage   61.53%   58.22%   -3.31%     
==========================================
  Files          11       14       +3     
  Lines        1292     1824     +532     
==========================================
+ Hits          795     1062     +267     
- Misses        497      762     +265     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dpo dpo merged commit 83bc164 into JuliaSmoothOptimizers:master Apr 9, 2025
13 of 14 checks passed
@MaxenceGollier MaxenceGollier deleted the ThetaDefault branch April 9, 2025 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants