Skip to content

Conversation

@MaxenceGollier
Copy link
Collaborator

@MaxenceGollier MaxenceGollier commented Sep 29, 2025

#231
This way if n is the max number of iterations, we make n iterations at most (instead of n+1 like before)

@MaxenceGollier MaxenceGollier mentioned this pull request Sep 29, 2025
6 tasks
@codecov
Copy link

codecov bot commented Sep 29, 2025

Codecov Report

❌ Patch coverage is 50.00000% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 86.15%. Comparing base (e0f214d) to head (2a4dbeb).
⚠️ Report is 203 commits behind head on master.

Files with missing lines Patch % Lines
src/utils.jl 50.00% 6 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           master     #233       +/-   ##
===========================================
+ Coverage   61.53%   86.15%   +24.62%     
===========================================
  Files          11       13        +2     
  Lines        1292     1575      +283     
===========================================
+ Hits          795     1357      +562     
+ Misses        497      218      -279     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@MaxenceGollier MaxenceGollier merged commit a4f927b into JuliaSmoothOptimizers:master Sep 29, 2025
12 of 14 checks passed
@MaxenceGollier MaxenceGollier deleted the max_iter branch September 29, 2025 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants