Skip to content

Conversation

@MaxenceGollier
Copy link
Collaborator

@codecov
Copy link

codecov bot commented Sep 30, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.43%. Comparing base (e0f214d) to head (2bc835a).
⚠️ Report is 205 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##           master     #241       +/-   ##
===========================================
+ Coverage   61.53%   84.43%   +22.90%     
===========================================
  Files          11       13        +2     
  Lines        1292     1632      +340     
===========================================
+ Hits          795     1378      +583     
+ Misses        497      254      -243     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a skip_sigma keyword argument to the obj functions of both R2NModel and LMModel classes. This allows callers to optionally exclude the sigma regularization term from the objective function computation.

  • Added skip_sigma keyword parameter to objective functions in both model types
  • Modified solver algorithms to use skip_sigma = true when computing model functions
  • Provides conditional logic to return objective values with or without regularization

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
src/R2NModel.jl Added skip_sigma kwarg to obj function with conditional return
src/LMModel.jl Added skip_sigma kwarg to obj function with conditional return
src/R2N.jl Updated solver to call obj with skip_sigma = true
src/LM_alg.jl Updated solver to call obj with skip_sigma = true

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@MaxenceGollier MaxenceGollier merged commit 7b54d4f into JuliaSmoothOptimizers:master Oct 1, 2025
13 of 14 checks passed
@MaxenceGollier MaxenceGollier deleted the skip_sigma branch October 1, 2025 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants