Skip to content

Conversation

@MohamedLaghdafHABIBOULLAH
Copy link
Collaborator

As discussed in Zulip this might reduce considerably the number of inner prox as for R2N and TR @dpo @MaxenceGollier

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a sub_kwargs parameter to the LMSolver to allow passing custom keyword arguments to the subsolver, which can help reduce the number of inner proximal iterations for solvers like R2N and TR.

  • Adds sub_kwargs parameter to both the documentation and function signature
  • Updates subsolver calls to include the new keyword arguments via splatting

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@codecov
Copy link

codecov bot commented Oct 3, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.68%. Comparing base (e0f214d) to head (80f981f).
⚠️ Report is 247 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##           master     #245       +/-   ##
===========================================
+ Coverage   61.53%   84.68%   +23.15%     
===========================================
  Files          11       13        +2     
  Lines        1292     1626      +334     
===========================================
+ Hits          795     1377      +582     
+ Misses        497      249      -248     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@MohamedLaghdafHABIBOULLAH
Copy link
Collaborator Author

Thanks @MaxenceGollier

@MohamedLaghdafHABIBOULLAH MohamedLaghdafHABIBOULLAH merged commit a6a05db into JuliaSmoothOptimizers:master Oct 3, 2025
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants