-
Notifications
You must be signed in to change notification settings - Fork 10
Add sigma_cauchy and scp_norm to solver statistics in all solvers #253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
… R2DH, R2N, and R2Solver
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds tracking of sigma_cauchy
and scp_norm
statistics to solver output across all trust-region and regularization-based solvers in the package. These statistics provide important diagnostic information about the solver's behavior at each iteration.
Key changes:
- Addition of
sigma_cauchy
(reciprocal of step size parameter) tracking - Addition of
scp_norm
(norm of the proximal gradient step) tracking - Consistent placement of these statistics after they are computed in each solver
Reviewed Changes
Copilot reviewed 7 out of 8 changed files in this pull request and generated 5 comments.
Show a summary per file
File | Description |
---|---|
src/TR_alg.jl | Added sigma_cauchy and scp_norm statistics tracking in the TR solver at initialization and main iteration loop |
src/TRDH_alg.jl | Added sigma_cauchy and scp_norm statistics tracking in the TRDH solver for both reduce_TR branches |
src/R2_alg.jl | Added scp_norm statistics tracking in the R2 solver at initialization and main iteration loop |
src/R2N.jl | Added scp_norm statistics tracking in the R2N solver at initialization and main iteration loop |
src/R2DH.jl | Added scp_norm statistics tracking and moved sigma_cauchy to after ν₁ is computed in the R2DH solver |
src/LM_alg.jl | Added sigma_cauchy and scp_norm statistics tracking in the Levenberg-Marquardt solver at initialization and main iteration loop |
src/LMTR_alg.jl | Added sigma_cauchy and scp_norm statistics tracking in the LMTR solver at initialization and main iteration loop |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #253 +/- ##
===========================================
+ Coverage 61.53% 84.67% +23.14%
===========================================
Files 11 13 +2
Lines 1292 1651 +359
===========================================
+ Hits 795 1398 +603
+ Misses 497 253 -244 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Would it also be useful to report |
I am not sure if the use of ‖ s k ‖ would be suitable for a stationary measure as in R2N we do not necessarily have ‖ s k ‖ < ‖ s k , c p ‖! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent,
I wonder if scp_norm
is a good name though. Since we have a sigma_cauchy
, wouldn't it be more appropriate to rename scp_norm
as step_cauchy_norm
or cauchy_point_norm
? Just an idea we might as well just keep scp_norm
.
Fix this 252