Paper draft #205
Closed
Paper draft #205
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MohamedLaghdafHABIBOULLAH
force-pushed
the
paper-draft
branch
from
e96129f to
5b9e859
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## paper #205 +/- ##
========================================
Coverage ? 59.36%
========================================
Files ? 15
Lines ? 1885
Branches ? 0
========================================
Hits ? 1119
Misses ? 766
Partials ? 0 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
This branch must be rebased. |
Co-authored-by: Maxence Gollier <134112149+MaxenceGollier@users.noreply.github.com>
MohamedLaghdafHABIBOULLAH
force-pushed
the
paper-draft
branch
from
fca3a30 to
2bb4f05
Compare
|
@dpo you may now begin the review of the paper. |
|
@MohamedLaghdafHABIBOULLAH You could also remove |
dpo
requested changes
Sep 7, 2025
MohamedLaghdafHABIBOULLAH
force-pushed
the
paper-draft
branch
from
0df3739 to
269bad8
Compare
MohamedLaghdafHABIBOULLAH
force-pushed
the
paper-draft
branch
from
6373690 to
bc756ee
Compare
|
@Loptima here is the joss paper. |
|
@MohamedLaghdafHABIBOULLAH Could you please add a workflow so the PDF is posted in the pull request? |
|
In fact, I tried it but it doesn’t work. |
Co-authored-by: Maxence Gollier <134112149+MaxenceGollier@users.noreply.github.com>
Co-authored-by: Maxence Gollier <134112149+MaxenceGollier@users.noreply.github.com>
MohamedLaghdafHABIBOULLAH
force-pushed
the
paper-draft
branch
from
f383661 to
3cb5071
Compare
MohamedLaghdafHABIBOULLAH
force-pushed
the
paper-draft
branch
from
3cb5071 to
a9a4985
Compare
MohamedLaghdafHABIBOULLAH
force-pushed
the
paper-draft
branch
from
da2caa1 to
872cbd0
Compare
…equirements section of paper.md
MohamedLaghdafHABIBOULLAH
force-pushed
the
paper-draft
branch
from
0897b0e to
fc1f5a6
Compare
|
@MohamedLaghdafHABIBOULLAH can you rebase ? |
…based framework section of paper.md
…for clarity and consistency
MohamedLaghdafHABIBOULLAH
force-pushed
the
paper-draft
branch
from
2a2cfec to
c0b0104
Compare
- Removed old Benchmark.tex file and replaced it with a new version containing updated results. - Consolidated benchmarking logic into a single Benchmark.jl file, removing separate benchmark-nnmf.jl and benchmark-svm.jl files. - Updated comparison-config.jl to modify tolerance values and adjust configurations for benchmarking. - Adjusted imports in Bench-utils.jl to remove unused dependencies and streamline the code. - Updated Project.toml to include new dependencies for PrettyTables and ProximalAlgorithms. - Modified the paper.md to correctly reference the new Benchmark.tex file location.
MohamedLaghdafHABIBOULLAH
force-pushed
the
paper-draft
branch
from
6092f8e to
401a77e
Compare
…solver in paper.md
MohamedLaghdafHABIBOULLAH
force-pushed
the
paper-draft
branch
from
401a77e to
ab8ef54
Compare
|
Treated by 242 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is the first version of the JOSS paper @dpo @MaxenceGollier and Youssef.
Please note that the
draft-paper.ymlworkflow file should be updated to work with the latest versions and to run on pull requests.Here is the pdf: paper.pdf