Skip to content

Conversation

@MaxenceGollier
Copy link
Collaborator

As discussed on zulip.

Solves your bug @MohamedLaghdafHABIBOULLAH

@codecov
Copy link

codecov bot commented Sep 30, 2025

Codecov Report

❌ Patch coverage is 70.73171% with 12 lines in your changes missing coverage. Please review.
✅ Project coverage is 84.62%. Comparing base (e0f214d) to head (ccdd7b3).
⚠️ Report is 206 commits behind head on master.

Files with missing lines Patch % Lines
src/R2DH.jl 0.00% 5 Missing ⚠️
src/R2N.jl 0.00% 5 Missing ⚠️
src/LMTR_alg.jl 66.66% 1 Missing ⚠️
src/TRDH_alg.jl 88.88% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           master     #240       +/-   ##
===========================================
+ Coverage   61.53%   84.62%   +23.09%     
===========================================
  Files          11       13        +2     
  Lines        1292     1620      +328     
===========================================
+ Hits          795     1371      +576     
+ Misses        497      249      -248     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@MohamedLaghdafHABIBOULLAH
Copy link
Collaborator

Thank you @MaxenceGollier, have you tested while incorporating the changes in this PR?

@MaxenceGollier
Copy link
Collaborator Author

No, it works even without these changes (on the nnmf problem)

@dpo
Copy link
Member

dpo commented Oct 1, 2025

I still think it's important to initialize $\sigma = 0$ in the model in #239.

@MaxenceGollier MaxenceGollier merged commit b868635 into JuliaSmoothOptimizers:master Oct 1, 2025
13 of 14 checks passed
@MaxenceGollier MaxenceGollier deleted the fix_bounds_init branch October 1, 2025 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants