Skip to content

Conversation

MohamedLaghdafHABIBOULLAH
Copy link
Collaborator

@dpo @MaxenceGollier this should be merged after 249.

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes the NNMF (Non-Negative Matrix Factorization) problem benchmarking code and cleans up dependencies. The changes eliminate the CFG2 configuration that was specifically used for NNMF benchmarks, remove ProximalOperators/ProximalAlgorithms dependencies in favor of ShiftedProximalOperators, and simplify solver naming in the remaining SVM benchmarks.

  • Removes all NNMF-related benchmark functions and workflow
  • Updates package dependencies to use ShiftedProximalOperators instead of ProximalOperators
  • Simplifies solver naming by removing problem type suffixes

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
paper/examples/example.jl Updates imports to use ShiftedProximalOperators and adds NLPModelsModifiers
paper/examples/comparison-config.jl Removes CFG2 configuration that was used for NNMF benchmarks
paper/examples/Project.toml Removes ProximalOperators, ProximalAlgorithms, and ProximalCore dependencies
paper/examples/Benchmark.jl Removes all NNMF benchmark functions and simplifies solver naming in SVM benchmarks

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@MohamedLaghdafHABIBOULLAH MohamedLaghdafHABIBOULLAH merged commit badc31f into JuliaSmoothOptimizers:paper Oct 21, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants