Skip to content

Add methods for adjusting p values #83

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
cjprybol opened this issue Oct 31, 2016 · 3 comments
Closed

Add methods for adjusting p values #83

cjprybol opened this issue Oct 31, 2016 · 3 comments

Comments

@cjprybol
Copy link

This is currently available in Julia via https://github.com/dirkschumacher/PValueAdjust.jl

Given that the functionality for calculating p values lives here in HypothesisTests, I thought it would be a good idea to try and implement Bonferroni, FDR, and FWER methods here as well. I saw open pull requests related to p values here #73 and here #76, but nothing for these simpler tests.

Mainly posting this here as a reminder to try and implement these myself, but any feedback on whether these already exist in JuliaStats and I missed them, that these tests should go elsewhere, or thumbs up/down voting that moving this functionality out of a the PValueAdjust package and into here is a good/bad idea is welcome

@ararslan
Copy link
Member

I've been meaning for a while to add p-value adjustments here, I just haven't gotten around to it.

@cjprybol
Copy link
Author

cjprybol commented Mar 4, 2017

@cjprybol cjprybol closed this as completed Mar 4, 2017
@ararslan
Copy link
Member

ararslan commented Mar 4, 2017

Good find, thanks Cameron.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants