Skip to content

Commit f4b677d

Browse files
committed
fix: small fixes
1 parent e3affc5 commit f4b677d

File tree

2 files changed

+3
-10
lines changed

2 files changed

+3
-10
lines changed

script/HelperConfig.s.sol

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -37,15 +37,13 @@ contract HelperConfig is CodeConstants, Script {
3737
address[] signers;
3838
}
3939

40-
constructor() {}
41-
4240
function getConfigByChainId(uint256 chainId) public returns (NetworkConfig memory) {
4341
if (chainId == LOCAL_CHAIN_ID) {
4442
return getOrCreateAnvilEthConfig();
4543
} else if (chainId == ETH_SEPOLIA_CHAIN_ID) {
46-
return getOrCreateSepoliaEthConfig();
44+
return getOrCreateSepoliaConfig();
4745
} else if (chainId == BASE_SEPOLIA_CHAIN_ID) {
48-
return getOrCreateSepoliaEthConfig();
46+
return getOrCreateSepoliaConfig();
4947
} else {
5048
revert HelperConfig__InvalidChainId();
5149
}
@@ -79,7 +77,7 @@ contract HelperConfig is CodeConstants, Script {
7977
});
8078
}
8179

82-
function getOrCreateSepoliaEthConfig() public returns (NetworkConfig memory) {
80+
function getOrCreateSepoliaConfig() public returns (NetworkConfig memory) {
8381
vm.startBroadcast();
8482
VerifierProveRSA65537SHA256 verifierProveRSA65537SHA256 = new VerifierProveRSA65537SHA256();
8583
VerifierProveRSA65537SHA1 verifierProveRSA65537SHA1 = new VerifierProveRSA65537SHA1();

test/unit/TestProofOfPassportRegister.t.sol

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -78,11 +78,6 @@ contract TestProofOfPassportRegister is Test, Script, CodeConstants {
7878
assertNotEq(verifier, address(0));
7979
assertEq(nullifierIndex, NULLIFIER_INDEX_IN_PUB_SIGNAL);
8080
assertEq(signatureAlgorithmIndexInPubSignals, SIGNATURE_ALGORITHM_INDEX_IN_PUB_SIGNALS);
81-
82-
// TODO: change this to test against the deployed values
83-
// if (block.chainid == LOCAL_CHAIN_ID) {
84-
// assertEq(owner, DEFAULT_ANVIL_ADDRESS);
85-
// }
8681
}
8782

8883
/*//////////////////////////////////////////////////////////////

0 commit comments

Comments
 (0)