Squad SepMotor Mesh fixes #2721
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes weird normals and fixes error spam due to restock trying to add depthmask onto a non restock mesh.
StonesmileGit
requested changes
Oct 26, 2022
| } | ||
|
|
||
| // Use RO-provided model instead of stock or Restock | ||
| @PART[sepMotor1]:NEEDS[ReStock]:FIRST { %RestockIgnore = True } |
There was a problem hiding this comment.
This line seems to prevent the ROSmallSpinMotor from loading
| @@ -1,4 +1,4 @@ | |||
| @PART[sepMotor1]:BEFORE[RealPlume] | |||
| @PART[sepMotor1|sepMotorSmall|sepMotorLarge|ROSmallSpinMotor]:BEFORE[RealPlume] | |||
There was a problem hiding this comment.
The plume size is the same on all of these parts with this patch. The plume should be scaled to match the scale of the specific part
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.