-
Notifications
You must be signed in to change notification settings - Fork 82
Implemented optional data validation #118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Masken8
wants to merge
20
commits into
Kampfkarren:master
Choose a base branch
from
Masken8:Validation
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
2cb36f0
Added optional validation to DataStore:Set and DataStore:Update
Masken8 21fd0e5
Change 2
Masken8 c6fecb1
Added request 1 and 3
Masken8 e25255a
Added unit test for validation
Masken8 c12c18f
assertValidatorWithDefaultError no longer uses pcall
Masken8 d808ebb
Fixed unit test
Masken8 81a1d81
Edited error messages
Masken8 f2e065b
Validator can return a message
Masken8 903f0d8
Fixed validate set unit test and added validate update unit test
Masken8 4d9cd6c
Update Tests/tests/DataStore2.spec.lua
Masken8 d79c4bb
Update Tests/tests/DataStore2.spec.lua
Masken8 2310328
Update DataStore2/init.lua
Masken8 998df5c
Update DataStore2/init.lua
Masken8 b336b08
Update DataStore2/init.lua
Masken8 d36a7fb
Update DataStore2/init.lua
Masken8 26579c4
Whitespace
Masken8 85b221b
Validators in unit tests no longer error themselves
Masken8 7d80f3d
Apply suggestions from code review
Masken8 9589023
Merge branch 'master' of https://github.com/Kampfkarren/Roblox into V…
Masken8 1f2b37e
Unit test fixed for real this time I think
Masken8 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.